[R-package] remove lgb.last_error() and LGBM_GetLastError_R() #4344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikerRUS
approved these changes
Jun 5, 2021
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that #4163 removed the last uses of the internal helper function
lgb.last_error()in the R package. This PR proposes removing that function and its C++ counterpart,LGBM_GetLastError_R(). It's no longer necessary for the R package to reach into the C++ side and get the last error, since as of #4163 and other refactoring, C++ calls will raise R errors whenever one is thrown.LightGBM/R-package/src/lightgbm_R.cpp
Lines 36 to 38 in 28c3c45
Removing this code should have all the usual benefits of removing unused code...faster compilation, smaller library size, reduced maintenance burden, etc.